cli/registry: support password dash stdin#7029
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Alexis Girault <agirault@nvidia.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
login-password-dash-stdin
branch
from
eeedf80 to
450df79
Compare
thaJeztah
approved these changes
Jun 12, 2026
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
this was something I was considering for a while (but probably never opened a ticket for) 😂
I did a quick rebase, and regenerated the markdown (which was the failure in CI)
vvoland
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support for
docker login --password -anddocker login -p -to read the password or PAT from stdin, matching the existing--password-stdinbehavior, and following the common CLI convention that-means stdin.The tradeoff is that
-can no longer be used as a literal password value through--password.Validation
make -f docker.Makefile test-unit&
docker run --rm -v "$PWD":/src -w /src golang:1.25 ./scripts/with-go-mod.sh go test -mod=mod ./cli/command/registry -run 'TestRunLogin/password_dash|TestLoginHelpDocumentsPasswordDash|TestLoginValidateFlags/(password_dash|short_password_dash|password_stdin_and_password_dash|conflicting_options)'Note
- Human readable description for the release notes